Rewrite#31
Merged
Merged
Conversation
andrefurlan-db
force-pushed
the
rewrite
branch
from
November 3, 2022 21:55
2b3ea2f to
a1f7fc7
Compare
This is a rewrite of the code to not rely on old impala code. This version is trimmer, and it allows us to support context cancelation properly. There has also been significant improvements in the testing strategy and framework. Signed-off-by: Andre Furlan <andre.furlan@databricks.com>
andrefurlan-db
force-pushed
the
rewrite
branch
from
November 3, 2022 23:24
a1f7fc7 to
aa8b0bb
Compare
andrefurlan-db
marked this pull request as ready for review
November 3, 2022 23:25
andrefurlan-db
requested review from
arikfr,
moderakh,
susodapop and
yunbodeng-db
as code owners
November 3, 2022 23:25
andrefurlan-db
requested review from
mattdeekay and
rcypher-databricks
and removed request for
arikfr,
moderakh,
susodapop and
yunbodeng-db
November 3, 2022 23:41
rcypher-databricks
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite 👍